PHPLIB-1627: BulkWriteCommand API #1630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
reviewed
Mar 4, 2025
GromNaN
reviewed
Mar 7, 2025
GromNaN
reviewed
Mar 17, 2025
jmikola
force-pushed
the
2.x-bulkwrite
branch
4 times, most recently
from
d9351cc to
33952f7
Compare
jmikola
force-pushed
the
2.x-bulkwrite
branch
3 times, most recently
from
f2cae41 to
c4c0deb
Compare
GromNaN
reviewed
Apr 4, 2025
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
GromNaN
reviewed
Apr 7, 2025
The transaction spec requires certain language, and this is now expected in spec test for clientBulkWrite.
Also fixes the return type for getBuilderEncoder()
GromNaN
reviewed
May 9, 2025
|
The spec tests need to be updated with mongodb/specifications@63e382e |
The previous failure was unrelated, but I'll update the spec tests once mongodb/mongo-php-driver#1822 is merged up to v2.x. |
There was a problem hiding this comment.
Pull Request Overview
This PR implements the new BulkWriteCommand API and refactors several test and client modules to align with the updated driver options and error messaging. Key changes include:
- Removing redundant test helper methods and refactoring driver option handling.
- Introducing new stub files and operation classes for BulkWriteCommand support.
- Updating tests to reflect newly designed error messages and encoder/codec accessors.
Reviewed Changes
Copilot reviewed 41 out of 41 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/SpecTests/ClientSideEncryption/FunctionalTestCase.php | Removed redundant createTestClient method to use inherited behavior. |
| tests/PedantryTest.php | Updated method filtering to re-index arrays and exclude non-public constructors. |
| tests/FunctionalTestCase.php | Refactored driver option handling with renamed method appendDriverOptions. |
| tests/Collection/CollectionFunctionalTest.php | Added tests for getBuilderEncoder and getCodec, and updated expected exception messages. |
| stubs/Driver/*.stub.php | Added stub files for new BulkWriteCommand API components. |
| src/Operation/ClientBulkWriteCommand.php | Introduced new operation for executing bulk write commands with updated options handling. |
| src/ClientBulkWrite.php | Implemented a fluent API for bulk write operations with proper option validations. |
| src/Client.php | Added bulkWrite method integrating the new BulkWriteCommand API. |
| Configuration files and workflows | Updated dependency versions and driver version settings with TODO notes. |
alcaeus
approved these changes
May 12, 2025
Co-authored-by: Copilot <[email protected]>
GromNaN
reviewed
May 12, 2025
GromNaN
reviewed
May 12, 2025
| @@ -12,7 +12,9 @@ on: | |||
| - "feature/*" | |||
|
|
|||
| env: | |||
| DRIVER_VERSION: "stable" | |||
| # TODO: change to "stable" once 2.0.0 is released | |||
There was a problem hiding this comment.
Suggested change
| # TODO: change to "stable" once 2.0.0 is released | |
| # TODO: change to "stable" once 2.1.0 is released |
GromNaN
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPLIB-1627
Requires mongodb/mongo-php-driver#1818