Support laravel 5.3 #925
Merged
Support laravel 5.3 #925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New Laravel queries always return collection. this is a backward compatible enhancement as Collections can be used as Arrays!
Closed
|
Hopes this gets merged, there is 1 test failing though , but is failing on master anyways |
This was referenced Aug 26, 2016
| * | ||
| * @var boolean | ||
| */ | ||
| protected $use_collection; |
There was a problem hiding this comment.
This should be camel case.
|
Hello , |
|
@alsemany True, but not related to this PR. according to official README, Supported relations are :
|
|
Any idea when this will be merged? I started a project in 5.3 just to find out that this repo is not compatible yet :/ |
|
@jenssegers any chance to merge this PR? |
|
I'll merge this, but I can only tag a new release once we have fixed some of the tests though. |
Closed
divine
added a commit
to divine/laravel-mongodb
that referenced
this pull request
Mar 4, 2020
Remove shouldUseCollections function which checks Laravel version > 5.3, it was introduced to support version 5.3 in mongodb#925
divine
added a commit
that referenced
this pull request
Sep 14, 2020
Remove shouldUseCollections function which checks Laravel version > 5.3, it was introduced to support version 5.3 in #925
mnphpexpert
added a commit
to mnphpexpert/laravel-mongodb
that referenced
this pull request
Sep 2, 2024
Initial support laravel 5.3
mnphpexpert
added a commit
to mnphpexpert/laravel-mongodb
that referenced
this pull request
Sep 2, 2024
Remove shouldUseCollections function which checks Laravel version > 5.3, it was introduced to support version 5.3 in mongodb#925
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Laravel queries always return collection. this is a backward compatible enhancement as Collections can be used as Arrays!