Skip to content

PHPORM-220 Deprecate using the $collection property to customize the name #3064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 23, 2024
Merged

PHPORM-220 Deprecate using the $collection property to customize the name #3064

merged 3 commits into from
Jul 23, 2024

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Jul 22, 2024 •
edited
Loading

Fix PHPORM-220

Similar to #3062 for the name of the collection. $table should be used instead of $collection.

Checklist

  • Add tests and ensure they pass
  • Add an entry to the CHANGELOG.md file
  • Update documentation for new features

@GromNaN GromNaN requested review from a team as code owners July 22, 2024 15:38
@GromNaN GromNaN requested a review from alcaeus July 22, 2024 15:38
@github-actions github-actions bot added the docs label Jul 22, 2024
@GromNaN GromNaN removed the docs label Jul 23, 2024
@GromNaN GromNaN requested a review from rustagir July 23, 2024 14:27
@github-actions github-actions bot added the docs label Jul 23, 2024
rustagir
rustagir approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@rustagir rustagir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@GromNaN GromNaN merged commit 046b92a into mongodb:4.8 Jul 23, 2024
26 checks passed
@GromNaN GromNaN deleted the PHPORM-220 branch July 23, 2024 15:19
@mongodb-php-bot mongodb-php-bot mentioned this pull request Jul 23, 2024
Merged
@GromNaN GromNaN mentioned this pull request Aug 19, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcaeus alcaeus alcaeus approved these changes

@rustagir rustagir rustagir approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GromNaN @alcaeus @rustagir