-
Notifications
You must be signed in to change notification settings - Fork 1.4k
DOCSP-41241: Laravel Sanctum #3050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say in the introduction that Laravel Sanctum work by overriding the default model with a model that brings MongoDB features. Everything else works the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple of suggestions about flow
docs/user-authentication.txt
Outdated
Customize User Authentication | ||
----------------------------- | ||
|
||
In this section, you can learn how to use the following features to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: before this sentence, add a sentence explaining why someone might want to make a custom model
docs/user-authentication.txt
Outdated
Laravel Sanctum | ||
~~~~~~~~~~~~~~~ | ||
|
||
You can install the Laravel Sanctum package to provide API tokens to users |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: add a sentence explaining broadly what laravel sanctum is
docs/user-authentication.txt
Outdated
|
||
You can install the Laravel Sanctum package to provide API tokens to users | ||
and authenticate single-page applications. To manage API tokens, Sanctum stores | ||
each token in a database table and authenticates incoming HTTP requests through |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
each token in a database table and authenticates incoming HTTP requests through | |
each token in a database table and authenticates incoming HTTP requests by using |
docs/user-authentication.txt
Outdated
To learn more about installing and configuring Laravel Sanctum, see the | ||
`Installation <https://laravel.com/docs/{+laravel-docs-version+}/sanctum#installation>`__ | ||
section of the Laravel Sanctum guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To learn more about installing and configuring Laravel Sanctum, see the | |
`Installation <https://laravel.com/docs/{+laravel-docs-version+}/sanctum#installation>`__ | |
section of the Laravel Sanctum guide. | |
To learn more about installing and configuring Laravel Sanctum, see | |
`Installation <https://laravel.com/docs/{+laravel-docs-version+}/sanctum#installation>`__ | |
in the Laravel Sanctum guide. |
docs/user-authentication.txt
Outdated
To use Laravel Sanctum with {+odm-short+}, you must modify the ``PersonalAccessToken`` | ||
model provided by Sanctum. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: provide a little more explanation of what is required here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
JIRA - https://jira.mongodb.org/browse/DOCSP-41241
Staging - https://preview-mongodbnorareidy.gatsbyjs.io/laravel/DOCSP-41241-stage/user-authentication/#customize-user-authentication
Checklist