Skip to content

[Updated PR#1476] Add explanation for database migration resets #1941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 5, 2020

Conversation

divine
Copy link
Contributor

@divine divine commented Jan 31, 2020

This PR was recreated from #1476 with updated branch or resolved conflicting files.

--

Add Database Testing to index.
use DatabaseMigrations; instead of use RefreshDatabase; for laravel 5.6 compatibility issue (#1475)

Co-Authored-By: theminer3746 [email protected]

@Giacomo92
Copy link

Giacomo92 commented Jan 31, 2020

I think both RefreshDatabase and DatabaseMigrations needs more tests. I have tried to use them without success. Next week I will have to work with this also for my projects. I will keep you updated @divine @Smolevich

@divine
Copy link
Contributor Author

divine commented Jan 31, 2020

I think both RefreshDatabase and DatabaseMigrations needs more tests. I have tried to use them without success. Next week I will have to work with this also for my projects. I will keep you updated @divine @Smolevich

Sure, I'm just trying to update/resolve PRs that doesn't have a breaking change, after that we could focus on actual bugs.

Thanks!

@Giacomo92
Copy link

Yep, I saw. Good job @divine
Sooner or later all pull requests will be closed

Smolevich
Smolevich previously approved these changes Feb 3, 2020
@Giacomo92
Copy link

I have added some tests on demo application here. @divine @Smolevich
I think it is better to write:

  • use DatabaseMigrations; -> working
  • use DatabaseTransactions; -> not working for now
  • use RefreshDatabase; -> not working for now

in order to avoid other issues to be opened.

@divine
Copy link
Contributor Author

divine commented Feb 4, 2020

@Smolevich @Giacomo92 @rennokki what you think guys?

@Smolevich
Copy link
Contributor

@Smolevich @Giacomo92 @rennokki what you think guys?

i think that it's ok

@Smolevich Smolevich merged commit ef147ea into mongodb:master Feb 5, 2020
@divine divine deleted the pr_1476 branch February 5, 2020 13:29
mnphpexpert added a commit to mnphpexpert/laravel-mongodb that referenced this pull request Sep 2, 2024
[Updated PR#1476] Add explanation for database migration resets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants