Skip to content

[refactor] Replaced Coveralls with Codecov #1922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 23, 2020
Merged

[refactor] Replaced Coveralls with Codecov #1922

merged 4 commits into from
Jan 23, 2020

Conversation

rennokki
Copy link
Contributor

@rennokki rennokki commented Jan 22, 2020 •
edited
Loading

I don't know why, but it seems like Coveralls is playing games, so i decided to switch it up with Codecov.

@jenssegers For this, a secret named CODECOV_TOKEN might be needed that can be obtained from here: https://codecov.io/gh

@rennokki rennokki mentioned this pull request Jan 22, 2020
Closed
@Smolevich
Copy link
Contributor

@rennokki register your fork in codecov.io and add CODECOV_TOKEN to secrets
All requests finished with 400 error code https://github.com/rennokki/laravel-mongodb/commit/46a1d6d956c5e254581b344aec87cc303af3b93c/checks?check_suite_id=414641074

@Smolevich
Copy link
Contributor

Problem with coveralls here php-coveralls/php-coveralls#275

@Smolevich
Copy link
Contributor

I will suggest compare codecov.io and coveralls.io and revert step with coveralls

@Smolevich
Copy link
Contributor

Smolevich commented Jan 22, 2020 •
edited
Loading

We can replace using library php-coveralls/php-coveralls on https://github.com/cedx/coveralls.php. I prepare PR https://github.com/cedx/coveralls.php/pull/9 for additional fields.

@Smolevich
Copy link
Contributor

I prepared #1923

@jenssegers
Copy link
Contributor

jenssegers commented Jan 23, 2020 •
edited
Loading

I've added the secret 👍

@jenssegers jenssegers merged commit 30e2000 into mongodb:master Jan 23, 2020
@Smolevich
Copy link
Contributor

@jenssegers , What about #1923 ?

@rennokki rennokki deleted the refactor/coveralls-to-codecov branch January 23, 2020 09:50
@jenssegers
Copy link
Contributor

We can still use #1923 if we were to revert to coveralls. I'm ok with trying out codecov. Mainly interested in what they will report through the github action.

@Smolevich
Copy link
Contributor

Ok, i suggest add two report services and compare

mnphpexpert added a commit to mnphpexpert/laravel-mongodb that referenced this pull request Sep 2, 2024
@mnphpexpert
Merge pull request mongodb#1922 from rennokki/refactor/coveralls-to-c…
c41aa44 
…odecov

[refactor] Replaced Coveralls with Codecov
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenssegers jenssegers jenssegers approved these changes

@Smolevich Smolevich Awaiting requested review from Smolevich

Assignees

@rennokki rennokki

Labels
Needs work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rennokki @Smolevich @jenssegers