Skip to content

[refactor] Readme #1917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jan 24, 2020
Merged

[refactor] Readme #1917

merged 20 commits into from
Jan 24, 2020

Conversation

rennokki
Copy link
Contributor

Managed to re-write a bunch of the configuration and re-thinking the examples a bit cuz some didn't make sense.

You can see the README here: https://github.com/rennokki/laravel-mongodb/tree/refactor/readme

Tree

@rennokki rennokki requested a review from Smolevich January 20, 2020 19:51
@rennokki
Copy link
Contributor Author

rennokki commented Jan 20, 2020

@Smolevich I don't think there are any other grammar errors. I used Grammarly and commited 7e91b7a

@Smolevich
Copy link
Contributor

@jenssegers please see on PR, are you agree with reformatting?

@divine
Copy link
Contributor

divine commented Jan 20, 2020

Well, if are going to refactor readme, we should take care for this PR #1121 too.

@divine
Copy link
Contributor

divine commented Jan 20, 2020

Also we need take care for this too #1830

@jenssegers
Copy link
Contributor

I like the structure. Probably a lot easier to find documentation with this new index.

@rennokki
Copy link
Contributor Author

This is how it's looking so far:

Screenshot 2020-01-23 at 12 30 18

Giacomo92
Giacomo92 previously approved these changes Jan 23, 2020
Smolevich
Smolevich previously approved these changes Jan 24, 2020
@rennokki
Copy link
Contributor Author

@Giacomo92 & @Smolevich

Final reviews?

@Smolevich Smolevich self-assigned this Jan 24, 2020
@Smolevich Smolevich merged commit 291b4d3 into mongodb:master Jan 24, 2020
@rennokki rennokki deleted the refactor/readme branch January 24, 2020 15:47
mnphpexpert added a commit to mnphpexpert/laravel-mongodb that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants