[Fix] Unable to delete nested embedded models #1423
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milanspv
changed the title
|
@jenssegers any updates on this? |
Merge latest from jenssegers/laravel-mongodb:master
|
@jenssegers This should be at least available on v3.3.x and Laravel 5.5 (LTS). |
|
@jenssegers Could you please review the PR and provide any kind of feedback? The review should be prioritized since it contains a fix for the core functionality that is not working properly in the current implementation. |
|
Merged, but GitHub did something weird :) |
|
@jenssegers what version of the package will this be available on? Ref: #1423 (comment) |
|
@milanspv v3.4.1 |
|
@jenssegers v3.4.1 requires Laravel 5.6. Any chance to make this available to those of us who work with Laravel 5.5 LTS (v3.3.x release)? |
D-02022020
pushed a commit
to hoffnungslabor/laravel-mongodb
that referenced
this pull request
Mar 1, 2018
[Fix] Unable to delete nested embedded models
mnphpexpert
added a commit
to mnphpexpert/laravel-mongodb
that referenced
this pull request
Sep 2, 2024
[Fix] Unable to delete nested embedded models
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fixes deletion of embedded nested objects.
The current implementation uses dot notation which in combination with
$setupdate operator does not actually remove objects.@jenssegers ^