Skip to content

Fix #1293: Exception: BelongsToMany Is Not supported for hybrid query constraints! #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

benargo
Copy link
Contributor

@benargo benargo commented Oct 9, 2017

This fixes issue #1293 where non-hybrid BelongsToMany relations were throwing the described exception.

This temporarily skirts around the issue described in the following issue: mongodb#1293
Without this statement, the reaffirming of belongsToMany relations would fail. The original commit was to prove a point in an issue, but for it to work in the real world this extra bit is added.
@benargo
Copy link
Contributor Author

benargo commented Oct 9, 2017

Not sure I can do anything to make the Travis CI build pass. 🤔

@benargo benargo closed this Oct 9, 2017
@vesper8
Copy link

vesper8 commented Oct 14, 2017

@benargo just wondering how come you closed your PR? did you find an alternative fix to the problem or was it resolved through another PR?

@benargo
Copy link
Contributor Author

benargo commented Oct 14, 2017

I need to do some more testing on it first, as I haven't attempted to replicate the issue on >3.2.3. I'm aiming to do this in the coming week.

@jim5359
Copy link
Contributor

jim5359 commented Apr 6, 2018

What ever happened to this fix? I'm having the same problem and the suggested fix works. It would be nice to get this into the mainline code.

@benargo
Copy link
Contributor Author

benargo commented Apr 10, 2018

I'm really sorry about the delay. I had the day off today and took the opportunity to revisit this PR.

I've made sure this change is compatible with the latest version (as I developed the original fix on a previous build). Your comments were very helpful with this as well.

I'm going to resubmit the PR.

jenssegers added a commit that referenced this pull request Apr 10, 2018
 Fix #1293: Exception: BelongsToMany Is Not supported for hybrid query constraints! #1324
@jim5359
Copy link
Contributor

jim5359 commented Apr 10, 2018

Awesome, thanks Ben!

D-02022020 pushed a commit to hoffnungslabor/laravel-mongodb that referenced this pull request Apr 20, 2018
Fix mongodb#1293: Exception: BelongsToMany Is Not supported for hybrid query constraints! mongodb#1324
mnphpexpert added a commit to mnphpexpert/laravel-mongodb that referenced this pull request Sep 2, 2024
 Fix mongodb#1293: Exception: BelongsToMany Is Not supported for hybrid query constraints! mongodb#1324
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants