Skip to content

Revert "fix sse endpoint path preservation" #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Revert "fix sse endpoint path preservation" #505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/client/sse.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ describe("SSEClientTransport", () => {
await transport.send(message);

// Verify the POST request maintains the custom path
expect(lastServerRequest.url).toBe("/custom/path/sse");
expect(lastServerRequest.url).toBe("/custom/path/messages");
});

it("handles multiple levels of custom paths", async () => {
Expand All @@ -107,7 +107,7 @@ describe("SSEClientTransport", () => {
await transport.send(message);

// Verify the POST request maintains the full custom path
expect(lastServerRequest.url).toBe("/api/v1/custom/deep/path/sse");
expect(lastServerRequest.url).toBe("/api/v1/custom/deep/path/messages");
});

it("maintains custom path for SSE connection", async () => {
Expand All @@ -130,7 +130,7 @@ describe("SSEClientTransport", () => {
};

await transport.send(message);
expect(lastServerRequest.url).toBe("/custom/path/sse");
expect(lastServerRequest.url).toBe("/custom/path/messages");
});

it("establishes SSE connection and receives endpoint", async () => {
Expand Down
8 changes: 7 additions & 1 deletion src/client/sse.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,13 @@ export class SSEClientTransport implements Transport {
this._endpoint = new URL(messageEvent.data, this._url);

// If the original URL had a custom path, preserve it in the endpoint URL
this._endpoint.pathname = this._url.pathname;
const originalPath = this._url.pathname;
if (originalPath && originalPath !== '/' && originalPath !== '/sse') {
// Extract the base path from the original URL (everything before the /sse suffix)
const basePath = originalPath.replace(/\/sse$/, '');
// The endpoint should use the same base path but with /messages instead of /sse
this._endpoint.pathname = basePath + '/messages';
}

if (this._endpoint.origin !== this._url.origin) {
throw new Error(
Expand Down