Skip to content

Add support for message field in progress notifications #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025

Conversation

bhosmer-ant
Copy link
Contributor

Summary

This PR implements support for the optional message field in progress notifications as defined in the MCP specification update (modelcontextprotocol/modelcontextprotocol#197).

Changes

  • Added optional message field to ProgressSchema in types.ts
  • Added comprehensive tests for progress notifications with message field in both protocol and server tests
  • Client and server implementations already support the new field through existing notification handling

Test plan

  • Run npm test - all tests pass
  • Run npm run lint - no linting errors
  • Run npm run build - builds successfully
  • Manual testing with a client/server implementation

🤖 Generated with Claude Code

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
karan925 Karan Singh
Implements the new optional message field for progress notifications as
defined in the MCP specification update. This allows servers to provide
descriptive status updates alongside progress values.

Changes:
- Add optional message field to ProgressSchema in types.ts
- Add tests for progress notifications with message field
- Update protocol tests to verify message field handling

Refs: modelcontextprotocol/modelcontextprotocol#197

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@bhosmer-ant bhosmer-ant requested a review from ihrpr May 16, 2025 19:21
Copy link
Contributor

@ihrpr ihrpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bhosmer-ant bhosmer-ant merged commit 69f8ee4 into main May 19, 2025
5 checks passed
@bhosmer-ant bhosmer-ant deleted the basil/progress_message branch May 19, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants