#21: Impelement rule

[larsroettig]

see #21

[lenaorobei]

Please see my comments.

[lenaorobei]

Have concerns regarding Technical Guidelines that says:

5.16. If a method uses system resources (such as files, sockets, streams, etc.), the code MUST be wrapped with a try block and the corresponding finally block. In the finally sections, all resources SHOULD be properly released.

1. Native PHP functions that work with resources (stream_*, socket_*) do not throw Exceptions or Errors, they mostly return false in case of failure and can produce E_WARNING. https://www.php.net/manual/en/sockets.errors.php
   https://www.php.net/manual/en/stream.errors.php
2. Magento app will transform E_WARNING to the Exception in Magento\Framework\App\ErrorHandler.
3. Magento Framework wrappers that work with resources solve E_WARNING by adding @, and do not have try catch blocks. Examples:
   https://github.com/magento/magento2/blob/2.3-develop/lib/internal/Magento/Framework/Filesystem/Driver/Http.php#L199
   https://github.com/magento/magento2/blob/2.3-develop/lib/internal/Magento/Framework/Backup/Filesystem/Rollback/Ftp.php#L93

My question is what is the right way to deal with such cases?
@akaplya @buskamuza @paliarush @melnikovi @kandy need your input here.

[lenaorobei]

@larsroettig this rule was approved on architects discussion magento/architecture#140

I'm going to test it and will provide you feedback.

[lenaorobei]

@larsroettig could you please remove curl_ from this sniff to make sure it's in line with Magento Technical Guidelines.

This is an adding new rule, so it will be the part of next major release.
I need to suspend the processing of current PR since the versioning strategy is not clear yet magento/architecture#136

Sorry about that and thanks for understanding.