Skip to content

#24: [New Rule] Static methods SHOULD NOT be used #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 27, 2019

Conversation

larsroettig
Copy link
Member

#24

@magento-cicd2
Copy link

magento-cicd2 commented Feb 19, 2019

CLA assistant check
All committers have signed the CLA.

@larsroettig larsroettig force-pushed the 24-static-method-sniff branch from 53cf44b to d5c1bb6 Compare February 20, 2019 09:18
@lenaorobei lenaorobei self-requested a review February 20, 2019 15:23
Copy link
Contributor

@lenaorobei lenaorobei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! Could please fix red build.
https://travis-ci.com/magento/magento-coding-standard/jobs/179094060#L543

@lenaorobei lenaorobei requested a review from paliarush February 20, 2019 16:20
@lenaorobei lenaorobei merged commit d55b20b into develop Feb 27, 2019
@lenaorobei lenaorobei deleted the 24-static-method-sniff branch February 28, 2019 15:02
magento-devops-reposync-svc pushed a commit that referenced this pull request Sep 1, 2021
…-coding-standard-244

[Imported] AC-948: Create unit test for Magento2\Less\PropertiesLineBreakSniff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants