Fix warnings detected by phpcs & phpunit #383
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on another change, I followed the instructions in the README which say to run
vendor/bin/phpunit && vendor/bin/phpcs --standard=Magento2 Magento2/ --extensions=php
. These reported errors which were unrelated to the changes I was making. This pull request solves those errors.For reference, the output of the above commands used to be:
and is now