Add semicolon as statement separator in the special annotation check of the Magento2.Security.XssTemplate
sniff
#378
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves special annotation detection of the
Magento2.Security.XssTemplate
sniff by addingT_SEMICOLON
as a statement separator. This resolves the issue that violations in a statement might be ignored by a special annotation in a previous/subsequent statement.For example, consider the following file:
This does not reported any violations of the
Magento2.Security.XssTemplate
sniff.However, the statements involving
$bar
and$baz
should report aFoundUnescaped
violation.This PR makes sure this is done, such that the following is reported: