Skip to content

Fixed undefined index in Magento2.Commenting.ClassPropertyPHPDocFormatting #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sivaschenko
Copy link
Member

Fixes: #315

The following tags have been added to allowed/expected tags between property name and phpdoc:

  • T_NS_SEPARATOR,
  • T_STRING,
  • T_COMMENT

Refactored the sniff implementation for better readability

Do not consider simple comment annotation opening with /* instead of /** as PHPDoc. If property annotation opens with /* instead of /** that will result in static tests failure with message Missing PHP DocBlock for class property.

@sivaschenko
Copy link
Member Author

@magento import pr to magento-commerce/magento-coding-standard

@m2-github-services
Copy link
Contributor

@sivaschenko the Pull Request is successfully imported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Magento2.Commenting.ClassPropertyPHPDocFormatting throws an error when processing typed class properties
4 participants