AC-678: Create phpcs sniff for ObsoleteResponseTest #311
Conversation
m2-community-project
bot
added
Progress: approved
and removed
Progress: ready for review
labels
| foreach ($this->obsoleteResponseMethods as $method) { | ||
| if ($tokens[$stringPos]['content'] === $method) { | ||
| $phpcsFile->addWarning( | ||
| sprintf('Contains obsolete response method: %s.', $method), |
There was a problem hiding this comment.
It may be not clear how these static tests failures should be addressed. Can we add a bit more information and replacement suggestion to the message:
I.e. "\Magento\Framework\App\ViewInterface::renderLayout method is deprecated. Please use \Magento\Framework\Controller\ResultInterface::renderResult instead."
...
"\Magento\Framework\App\Action\Action::_redirect" method is deprecated. Please use \Magento\Backend\Model\View\Result\Redirect instead.
...
"\Magento\Backend\App\AbstractAction::_addBreadcrumb method is deprecated. Please use \Magento\Backend\Model\View\Result\Page::addBreadcrumb instead."
and so on
There was a problem hiding this comment.
I think this can be implemented by having $obsoleteResponseMethods as associative array
There was a problem hiding this comment.
Done, please @sivaschenko review! thanks
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: approved
labels
m2-community-project
bot
added
Progress: approved
Progress: review
and removed
Progress: changes requested
Progress: approved
labels
|
@magento import pr to magento-commerce/magento-coding-standard |
|
@eliseacornejo the Pull Request is successfully imported. |
No description provided.