Fix TypeError for phpcs->addWarning() #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fatal error: Uncaught TypeError: vsprintf(): Argument magento#2 ($values) must be of type array, int given in /srv/www/vendor/squizlabs/php_codesniffer/src/Files/File.php:1056 Stack trace: #0 /srv/www/vendor/squizlabs/php_codesniffer/src/Files/File.php(1056): vsprintf('Direct throw of...', 531) magento#1 /srv/www/vendor/squizlabs/php_codesniffer/src/Files/File.php(706): PHP_CodeSniffer\Files\File->addMessage(false, 'Direct throw of...', 67, 4, 'FoundDirectThro...', 531, 8, false) magento#2 /srv/www/vendor/magento/magento-coding-standard/Magento2/Sniffs/Exceptions/DirectThrowSniff.php(48): PHP_CodeSniffer\Files\File->addWarning('Direct throw of...', 526, 'FoundDirectThro...', 531) magento#3 /srv/www/vendor/squizlabs/php_codesniffer/src/Files/File.php(498): Magento2\Sniffs\Exceptions\DirectThrowSniff->process(Object(PHP_CodeSniffer\Files\LocalFile), 526) magento#4 /srv/www/vendor/squizlabs/php_codesniffer/src/Files/LocalFile.php(92): PHP_CodeSniffer\Files\File->process() #5 /srv/www/vendor/squizlabs/php_codesniffer/src/Runner.php(630): PHP_CodeSniffer\Files\LocalFile->process() magento#6 /srv/www/vendor/squizlabs/php_codesniffer/src/Runner.php(434): PHP_CodeSniffer\Runner->processFile(Object(PHP_CodeSniffer\Files\LocalFile)) magento#7 /srv/www/vendor/squizlabs/php_codesniffer/src/Runner.php(114): PHP_CodeSniffer\Runner->run() magento#8 /srv/www/vendor/squizlabs/php_codesniffer/bin/phpcs(18): PHP_CodeSniffer\Runner->runPHPCS() magento#9 {main} thrown in /srv/www/vendor/squizlabs/php_codesniffer/src/Files/File.php on line 1056
ihor-sviziev
approved these changes
May 26, 2021
m2-community-project
bot
added
Progress: approved
and removed
Progress: ready for review
labels
|
@sivaschenko please review |
|
Hi @fredden, |
…standard into vsprintf
|
Easiest way to reproduce is to run
|
ihor-sviziev
added a commit
to ihor-sviziev/magento-coding-standard
that referenced
this pull request
Jul 27, 2021
ihor-sviziev
approved these changes
Jul 27, 2021
There was a problem hiding this comment.
Hi,
I tested these changes on top of PHP 8 - works fine.
Before these changes:
❌ We have an error
https://github.com/magento/magento-coding-standard/runs/3170690636
After:
✔ No errors
https://github.com/magento/magento-coding-standard/runs/3170628234
sivaschenko
approved these changes
Jul 28, 2021
|
@magento import pr to magento-commerce/magento-coding-standard |
|
@sivaschenko the pull request successfully imported. |
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Mar 28, 2023
…o-coding-standard-426 [Imported] Fix PHP error with short class names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Argument 4 of PHP_CodeSniffer->addWarning() must be an array; integer given.
https://github.com/squizlabs/PHP_CodeSniffer/blob/a71aad2074891a5fc4b2f7e891282c9333830efd/src/Files/File.php#L683