Skip to content

codesniffer 3.4 support #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sergeynezbritskiy opened this issue Apr 13, 2019 · 3 comments
Closed

codesniffer 3.4 support #84

sergeynezbritskiy opened this issue Apr 13, 2019 · 3 comments
Labels
accepted New rule is accepted enhancement Improvements to existing rules

Comments

@sergeynezbritskiy
Copy link
Contributor

Preconditions

Together with this coding standard I'm trying to use this coding standard https://github.com/slevomat/coding-standard for checking php7 features.
Unfortunatelly this library requires codesniffer ^3.4.2, but magento coding standard requires codesnifer ~3.3.0 which means less the 3.4.0.

What about supporting Codesniffer 3.4 ?
@sergeynezbritskiy sergeynezbritskiy added the bug Something isn't working label Apr 13, 2019
@lenaorobei lenaorobei added enhancement Improvements to existing rules accepted New rule is accepted and removed bug Something isn't working labels Apr 15, 2019
@lenaorobei
Copy link
Contributor

Hi @sergeynezbritskiy that's definitely in our roadmap and there should be no issues with that. I added this issue to the community dashboard. You are vey welcome to open PR with version upgrade if you are interested in taking care of it.

One thing we need to take into account is magento dependency update as well.
https://github.com/magento/magento2/blob/2.3-develop/composer.json#L94

@lenaorobei
Copy link
Contributor

Fixed in #85
Thank you @sergeynezbritskiy!

@cmuench
Copy link

cmuench commented Apr 18, 2019

This change is good. But please keep an eye on backwards compatibility. We added the package via composer in our gitlab-ci pipeline. Every module which checks agains the latest Magento 2.3.1 is now broken.

magento-devops-reposync-svc pushed a commit that referenced this issue Sep 30, 2021
@eliseacornejo
Merge pull request #84 from magento-commerce/imported-eliseacornejo-m…
dc56f12 
…agento-coding-standard-296

[Imported] AC-679: Create phpcs static check for ObsoleteSystemConfigurationTest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted New rule is accepted enhancement Improvements to existing rules
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cmuench @sergeynezbritskiy @lenaorobei