Skip to content

[New Rule] Improper Date/Time handling #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lenaorobei opened this issue Mar 21, 2019 · 0 comments
Closed

[New Rule] Improper Date/Time handling #70

lenaorobei opened this issue Mar 21, 2019 · 0 comments
Labels
new rule New feature implementation

Comments

@lenaorobei
Copy link
Contributor

Problem

Magento2.PHP.DateTime.Overcomplicated relies on class name only and does not any additional checks (like instanceof). This causes false-positive findings.

Solution

Remove Magento2.PHP.DateTime.Overcomplicated sniff from Magento Coding Standard.
Implement this check using static tool that can analyze extended class info (PHPStan).

Keep the ticket open to track the rule implementation.

@paliarush
@lenaorobei lenaorobei added need to discuss Rule requires discussion false positive Rule causes false positive findings new rule New feature implementation labels Mar 21, 2019
@lenaorobei lenaorobei mentioned this issue Mar 21, 2019
Merged
@lenaorobei lenaorobei removed the false positive Rule causes false positive findings label Mar 21, 2019
@lenaorobei lenaorobei removed the need to discuss Rule requires discussion label Aug 9, 2019
magento-devops-reposync-svc pushed a commit that referenced this issue Sep 22, 2021
@eliseacornejo
Merge pull request #70 from magento-commerce/imported-eliseacornejo-m…
c5dbf03 
…agento-coding-standard-279

[Imported] AC-1307: PHP Syntax errors in xml files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new rule New feature implementation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lenaorobei