You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The future direction of magento/magento-coding-standard project is to deliver unified Coding Standard to the Magento core.
For backward compatibility dev/tests/static/framework/Magento/ruleset.xml should not be removed. In this case both coding standards will have name Magento and PHP CodeSniffer will be not able to process it.
Magento2 is definitely not a proper vendor name and goes against any proper versioning policy, including you recent proposal. Currently https://github.com/magento/magento-coding-standard is quite confusing as it contains "Magento Coding Standard" and "Magento2 Coding Standard" on the same page.
Problem overview
The future direction of magento/magento-coding-standard project is to deliver unified Coding Standard to the Magento core.
For backward compatibility dev/tests/static/framework/Magento/ruleset.xml should not be removed. In this case both coding standards will have name
Magento
and PHP CodeSniffer will be not able to process it.Solution
Rename
Magento
magento/magento-coding-standard toMagentoCS
. So dev/tests/static/framework/Magento/ruleset.xml will look like:The text was updated successfully, but these errors were encountered: