Skip to content

PHP 7.4 compatibility #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lenaorobei opened this issue Aug 17, 2020 · 1 comment · Fixed by #192
Closed

PHP 7.4 compatibility #191

lenaorobei opened this issue Aug 17, 2020 · 1 comment · Fixed by #192
Assignees
@lenaorobei
Labels
bug Something isn't working Progress: done

Comments

@lenaorobei
Copy link
Contributor

lenaorobei commented Aug 17, 2020 •
edited
Loading

Steps to reproduce

See travis build results https://travis-ci.com/github/magento/magento-coding-standard/jobs/372726109

Expected result

Job passes without deprecation warning

Actual result

Job fails with Array and string offset access syntax with curly braces is deprecated
@lenaorobei lenaorobei added the bug Something isn't working label Aug 17, 2020
@m2-assistant
Copy link

m2-assistant bot commented Aug 17, 2020

Hi @lenaorobei. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this

lenaorobei added a commit that referenced this issue Aug 17, 2020
@lenaorobei
#191: PHP 7.4 compatibility
b35e3a4 
- update PHP_CodeSniffer version
@lenaorobei lenaorobei self-assigned this Aug 17, 2020
@lenaorobei lenaorobei mentioned this issue Aug 17, 2020
Merged
magento-devops-reposync-svc pushed a commit that referenced this issue Jun 30, 2022
@sivaschenko
Merge pull request #191 from magento-commerce/imported-bl4de-magento-…
c2e4f0a 
…coding-standard-410

[Imported] Fix Rector tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lenaorobei lenaorobei

Labels
bug Something isn't working Progress: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PHP 7.4 compatibility magento/magento-coding-standard
1 participant
@lenaorobei