Skip to content

Using coding standard as s reference is causing error #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lenaorobei opened this issue Sep 24, 2019 · 0 comments
Closed

Using coding standard as s reference is causing error #144

lenaorobei opened this issue Sep 24, 2019 · 0 comments
Labels
bug Something isn't working Progress: good first issue Issues is easy to get started with

Comments

@lenaorobei
Copy link
Contributor

develop branch is not working with Magento 2 codebase

Preconditions

  1. Have cloned magento/magento2

Steps to reproduce

  1. Change composer.json dependency to "magento/magento-coding-standard": "dev-develop"
  2. Run composer update magento/magento-coding-standard
  3. Run
    • vendor/bin/phpcs --standard=dev/tests/static/framework/Magento/ruleset.xml app/code
      or
    • php vendor/bin/phpunit dev/tests/static/phpunit.xml.dist

Expected result

Check is running without errors.

Actual result

Fatal error: Uncaught Error: Class 'Magento2\Sniffs\Commenting\PHPDocFormattingValidator' not found in vendor/magento/magento-coding-standard/Magento2/Sniffs/Commenting/ClassAndInterfacePHPDocFormattingSniff.php:36

@lenaorobei lenaorobei added bug Something isn't working Progress: good first issue Issues is easy to get started with labels Sep 24, 2019
lenaorobei added a commit that referenced this issue Sep 27, 2019
@lenaorobei
#144: Using coding standard as s reference is causing error
0f59dca
@lenaorobei lenaorobei mentioned this issue Sep 27, 2019
Merged
magento-devops-reposync-svc pushed a commit that referenced this issue Jan 11, 2022
@svera
Merge pull request #144 from magento-commerce/imported-fredden-magent…
9b5eee9 
…o-coding-standard-348

[Imported] Allow use of modern syntax in JavaScript files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Progress: good first issue Issues is easy to get started with
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lenaorobei