Skip to content

Add excludes for test files #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lenaorobei opened this issue Aug 26, 2019 · 5 comments
Open

Add excludes for test files #136

lenaorobei opened this issue Aug 26, 2019 · 5 comments
Assignees
@konarshankar07
Labels
enhancement Improvements to existing rules Progress: dev in progress Progress: good first issue Issues is easy to get started with

Comments

@lenaorobei
Copy link
Contributor

Description

All rules that do not apply on test files need to have one more exclude.

<exclude-pattern>*/tests/*</exclude-pattern>

AC
@lenaorobei lenaorobei added enhancement Improvements to existing rules Progress: good first issue Issues is easy to get started with labels Aug 26, 2019
@konarshankar07 konarshankar07 self-assigned this Aug 31, 2019
@konarshankar07
Copy link
Contributor

Fixed in #138

@konarshankar07
Copy link
Contributor

Hello @lenaorobei,
I'm still working on creating additional PR in Magento 2 repo where I'll remove false skip annotation
Thanks

lenaorobei added a commit that referenced this issue Sep 4, 2019
@lenaorobei
Merge pull request #138 from konarshankar07/136-add-excludes-for-test…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
24607be 
…-files

#136 : Add excludes for test files
@lenaorobei
Copy link
Contributor Author

@konarshankar07 great, it can be done right after new release and dependency update https://github.com/magento/magento2/blob/2.3-develop/composer.json#L90

@konarshankar07
Copy link
Contributor

@lenaorobei then I'll wait till the next release

@konarshankar07
Copy link
Contributor

Hello @lenaorobei ,
Should I start creating the PR in magento 2 repo?
Thanks

magento-devops-reposync-svc pushed a commit that referenced this issue Dec 16, 2021
@m2-github-services
[Imported] AC-1717: Passing null to non-nullable internal function pa…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
3230fbb 
…rameters is… (#136)

* AC-1717: Passing null to non-nullable internal function parameters is deprecated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@konarshankar07 konarshankar07

Labels
enhancement Improvements to existing rules Progress: dev in progress Progress: good first issue Issues is easy to get started with
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lenaorobei @konarshankar07