Skip to content

Commit c539ed4

Browse files
MC-19366: Fixes order of rules and silences GraphQL field name validation
1 parent 43ef0a4 commit c539ed4

File tree

1 file changed

+24
-25
lines changed

1 file changed

+24
-25
lines changed

Magento2/ruleset.xml

Lines changed: 24 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -364,6 +364,30 @@
364364
<severity>6</severity>
365365
<type>warning</type>
366366
</rule>
367+
<rule ref="Magento2.GraphQL.ValidArgumentName">
368+
<severity>6</severity>
369+
<type>warning</type>
370+
</rule>
371+
<rule ref="Magento2.GraphQL.ValidEnumValue">
372+
<severity>6</severity>
373+
<type>warning</type>
374+
</rule>
375+
<rule ref="Magento2.GraphQL.ValidFieldName">
376+
<!--
377+
* Field name validation deactivated as per request
378+
* https://github.com/magento/magento-coding-standard/pull/141#discussion_r323349939
379+
-->
380+
<severity>0</severity>
381+
<type>warning</type>
382+
</rule>
383+
<rule ref="Magento2.GraphQL.ValidTopLevelFieldName">
384+
<severity>6</severity>
385+
<type>warning</type>
386+
</rule>
387+
<rule ref="Magento2.GraphQL.ValidTypeName">
388+
<severity>6</severity>
389+
<type>warning</type>
390+
</rule>
367391
<rule ref="Magento2.Whitespace.MultipleEmptyLines">
368392
<severity>6</severity>
369393
<type>warning</type>
@@ -522,31 +546,6 @@
522546
<rule ref="Squiz.WhiteSpace.SuperfluousWhitespace.EmptyLines">
523547
<severity>0</severity>
524548
</rule>
525-
<rule ref="Magento2.GraphQL.ValidTypeName">
526-
<severity>6</severity>
527-
<type>warning</type>
528-
</rule>
529-
<rule ref="Magento2.GraphQL.ValidFieldName">
530-
<!--
531-
* Field name validation deactivated as per request
532-
* https://github.com/magento/magento-coding-standard/pull/141#discussion_r323349939
533-
-->
534-
<exclude name="Magento2.GraphQL.ValidFieldName" />
535-
<severity>6</severity>
536-
<type>warning</type>
537-
</rule>
538-
<rule ref="Magento2.GraphQL.ValidArgumentName">
539-
<severity>6</severity>
540-
<type>warning</type>
541-
</rule>
542-
<rule ref="Magento2.GraphQL.ValidTopLevelFieldName">
543-
<severity>6</severity>
544-
<type>warning</type>
545-
</rule>
546-
<rule ref="Magento2.GraphQL.ValidEnumValue">
547-
<severity>6</severity>
548-
<type>warning</type>
549-
</rule>
550549

551550
<!-- Severity 5 warnings: PHPDoc formatting and commenting issues. -->
552551
<rule ref="Magento2.Commenting.ClassAndInterfacePHPDocFormatting">

0 commit comments

Comments
 (0)