Skip to content

Commit 43ef0a4

Browse files
MC-19366: Removes obsolete TODOs
1 parent c574003 commit 43ef0a4

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

PHP_CodeSniffer/Tokenizers/GRAPHQL.php

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,15 @@ class GRAPHQL extends Tokenizer
1919
/**
2020
* Defines how GraphQL token types are mapped to PHP token types.
2121
*
22+
* This is a complete list of all token types supported by <kbd>webonyx/graphql-php</var>. <knd>null</kbd> values
23+
* are automatically mapped to <kbd>T_STRING</kbd> but are noted as <kbd>null</kbd> in this list to improve
24+
* maintenance at a glance.
25+
*
2226
* @var array
2327
*/
2428
private $tokenTypeMap = [
2529
Token::AT => 'T_DOC_COMMENT_TAG',
26-
Token::BANG => null, //TODO Should we map this to a specific type
30+
Token::BANG => null,
2731
Token::BLOCK_STRING => 'T_COMMENT',
2832
Token::BRACE_L => 'T_OPEN_CURLY_BRACKET',
2933
Token::BRACE_R => 'T_CLOSE_CURLY_BRACKET',
@@ -34,12 +38,12 @@ class GRAPHQL extends Tokenizer
3438
Token::DOLLAR => 'T_DOLLAR',
3539
Token::EOF => 'T_CLOSE_TAG',
3640
Token::EQUALS => 'T_EQUAL',
37-
Token::FLOAT => null, //TODO Should we map this to a specific type
38-
Token::INT => null, //TODO Should we map this to a specific type
41+
Token::FLOAT => null,
42+
Token::INT => null,
3943
Token::NAME => 'T_STRING',
4044
Token::PAREN_L => 'T_OPEN_PARENTHESIS',
4145
Token::PAREN_R => 'T_CLOSE_PARENTHESIS',
42-
Token::PIPE => null, //TODO Should we map this to a specific type
46+
Token::PIPE => null,
4347
Token::SPREAD => 'T_ELLIPSIS',
4448
Token::SOF => 'T_OPEN_TAG',
4549
Token::STRING => 'T_STRING',
@@ -52,14 +56,13 @@ class GRAPHQL extends Tokenizer
5256
*/
5357
private $keywordTokenTypeMap = [
5458
'enum' => 'T_CLASS',
55-
'extend' => 'T_EXTENDS', //TODO This might not be the appropriate equivalent
59+
'extend' => 'T_EXTENDS',
5660
'interface' => 'T_INTERFACE',
5761
'implements' => 'T_IMPLEMENTS',
5862
'type' => 'T_CLASS',
5963
'union' => 'T_CLASS',
6064
'query' => 'T_FUNCTION',
6165
'mutation' => 'T_FUNCTION',
62-
//TODO We may have to add further types
6366
];
6467

6568
/**

0 commit comments

Comments
 (0)