This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Add information about ignoreTmpls property #6873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magento-engcom-team
added
Partner: Atwix
partners-contribution
|
An admin must run tests on this PR before it can be merged. |
rogyar
suggested changes
Mar 16, 2020
| defaults: { | ||
| value: 'some component value', | ||
| property: '${ $.value }', // equal to 'some component value' after component initialization | ||
| propertyIgnoreTempls: '${ $.value }', // equal to '${ $.value }' after component initialization |
There was a problem hiding this comment.
This part might be confusing. We may either remove property or add an extra comment for propertyIgnoreTempls that propertyIgnoreTempls is the property for which template literals will be ignored. Also, we may add an extra comment to ignoreTmpls that this section contains list of properties with template literals ignored.
rogyar
added
the
Technical
|
Hi @rogyar |
rogyar
approved these changes
Mar 25, 2020
dobooth
approved these changes
Mar 25, 2020
dobooth
added
Major Update
|
running tests |
|
Hi @serhiyzhovnir, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request (PR) adds information about
ignoreTmplsproperty.Affected DevDocs pages
Links to Magento source code
whatsnew
Added a 'ignoreTmpls property' section to Template Literals in UI Components page.