Skip to content

Agora integrationn - Split into Video and Screen share Stream #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

FalkWolsky
Copy link
Contributor

Proposed changes

We decided to offer two different components for Camera Video Stream and Screen Share Video-Stream.
Also, we made a handful of fixes for the Frontend

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

The breaking changes are related to Video Stream handling. You would need to adapt your Video-Applications.
Also, we made a change for KeyCloak OAuth Data. Instead of InstanceID we have now BaseURL and support the full URL String.

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Copy link

netlify bot commented Nov 21, 2023

Deploy Preview for lowcoder-test ready!

Name Link
🔨 Latest commit 39bbd15
🔍 Latest deploy log https://app.netlify.com/sites/lowcoder-test/deploys/655ca0931648db000830049a
😎 Deploy Preview https://deploy-preview-513--lowcoder-test.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@FalkWolsky FalkWolsky merged commit c02d325 into dev Nov 21, 2023
@FalkWolsky FalkWolsky deleted the agora-integrationn branch November 21, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants