Skip to content

Add loading animation to swap processing step #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 11, 2020
Merged

Conversation

jamaljsr
Copy link
Member

@jamaljsr jamaljsr commented May 8, 2020

Closes #30

This PR adds support for lottie animations. I added a temporary loading animation to the swap processing step. This will be replaced in the future with the animation in the Invision design, once it is provided by Lee.

To test, run yarn to install the new dependencies, create a swap and confirm you see a loading animation on the last step.

@jamaljsr jamaljsr requested a review from guggero May 8, 2020 16:00
Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇
Looks really nice!

@jamaljsr jamaljsr merged commit cd2759e into master May 11, 2020
@jamaljsr jamaljsr deleted the feat/animations branch May 11, 2020 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add loading animation for when a loop is being submitted
2 participants