Skip to content

[Custom Transactions] Add TxBuilder trait, support fixed additional outputs #3775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

[Custom Transactions] Add TxBuilder trait, support fixed additional outputs #3775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2a67aab
Remove broadcaster_dust_limit_sat, feerate_per_kw
tankyleo May 9, 2025
e1fe0b8
Remove total_anchors_sat
tankyleo May 9, 2025
c271d78
Add TxBuilder::{commit_tx_fee_sat, balances_excluding_tx_fee}
tankyleo May 9, 2025
fd6989e
Fold anchor amounts in new_for_{inbound, outbound}_channel
tankyleo May 12, 2025
d3dbb0d
Fold anchor amounts in get_available_balances_for_scope
tankyleo May 12, 2025
0fcf259
Fold anchor amounts in update_add_htlc
tankyleo May 12, 2025
fa5cbc4
Fold anchor amounts in can_accept_incoming_htlc
tankyleo May 12, 2025
428c04e
Remove commit_tx_fee_sat in build_commitment_no_state_update
tankyleo May 12, 2025
e59ed5f
Remove commit_tx_fee_sat in next_{local, remote}_commit_tx_fee_msat
tankyleo May 12, 2025
43a8ebd
Remove commit_tx_fee_sat in send_update_fee
tankyleo May 12, 2025
7fc2092
Add TxBuilder::build_commitment_transaction
tankyleo May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions lightning/src/ln/chan_utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,6 +622,21 @@ impl HTLCOutputInCommitment {
&& self.cltv_expiry == other.cltv_expiry
&& self.payment_hash == other.payment_hash
}

pub(crate) fn is_dust(&self, feerate_per_kw: u32, broadcaster_dust_limit_sat: u64, features: &ChannelTypeFeatures) -> bool {
let htlc_tx_fee_sat = if features.supports_anchors_zero_fee_htlc_tx() {
0
} else {
let htlc_tx_weight = if self.offered {
htlc_timeout_tx_weight(features)
} else {
htlc_success_tx_weight(features)
};
// As required by the spec, round down
feerate_per_kw as u64 * htlc_tx_weight / 1000
};
self.amount_msat / 1000 < broadcaster_dust_limit_sat + htlc_tx_fee_sat
}
}

impl_writeable_tlv_based!(HTLCOutputInCommitment, {
Expand Down
Loading
Loading