-
Notifications
You must be signed in to change notification settings - Fork 899
Test native libraries using docker for multiple distros #1921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@bording may you have a look on this PR? |
0411af1
to
eb28eef
Compare
This PR has some interesting ideas, but it's clear that it's been ported over from another repo (GitVersion?), so it has things that we don't need if we're actually part of this repo. Thoughts while looking at the PR:
Thoughts? |
This was needed at the time the NativeLibraries was not published to nuget and that was the reason in the PR for the NativeLibraries I included publishing to GitHub Packages.
|
That is true, I use the same docker images to test |
eeab039
to
2e33fc9
Compare
@bording I reworked the PR. Now the tests are run inside of docker containers for several distros and .net versions. Unfortunately I had to disable te |
474472e
to
5101c89
Compare
5101c89
to
bd7f5da
Compare
Thanks for the PR. Eventually I think want to move to use docker images that are in this repo to give a bit more control. For example, I'd prefer to always use the latest SDK, and then have additional runtimes installed as needed for the tests. That can be done later, and this is a great first step! |
To hopefully get the version that has native libaries pulled in nicely. Relates to libgit2/libgit2sharp#1921
To get the version that has native libaries pulled in nicely. Relates to libgit2/libgit2sharp#1921
To get the version that has native libaries pulled in nicely. Relates to libgit2/libgit2sharp#1921
Adds a test project that references the LibGit2Sharp.
Adds a
native-test
GitHub workflow that builds and the runs the test project to test the native libraries are loaded properlyThis test project is build inside a docker image and the the docker image is run