Skip to content

[12.x] Be more specific about usage of recycle() #10377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions eloquent-factories.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Eloquent: Factories
one# Eloquent: Factories
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure, the "one" is supposed to be there?


- [Introduction](#introduction)
- [Defining Model Factories](#defining-model-factories)
Expand Down Expand Up @@ -616,7 +616,8 @@ public function definition(): array
<a name="recycling-an-existing-model-for-relationships"></a>
### Recycling an Existing Model for Relationships

If you have models that share a common relationship with another model, you may use the `recycle` method to ensure a single instance of the related model is recycled for all of the relationships created by the factory.
For factories that include relationships, you may use the `recycle` method to ensure a single instance of the related model is recycled for all of the relationships created by the factory.
For relationships outside of the factory (like a many-to-many), see [HasAttached()](#pivot-table-attributes).
Comment on lines +619 to +620
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if the first part is needed since we are already on the "Factories" docs page. Furthermore, I'd assume, you would need yet another line break to make Markdown render the second part as a separate paragraph.


For example, imagine you have `Airline`, `Flight`, and `Ticket` models, where the ticket belongs to an airline and a flight, and the flight also belongs to an airline. When creating tickets, you will probably want the same airline for both the ticket and the flight, so you may pass an airline instance to the `recycle` method:

Expand Down