🐛Use k8s.io/apimachinery/pkg/util/json to unmarshal in fakeclient

[troy0820]

This will use k8s.io/apimachinery/pkg/util/json which calls sigs.k8s.io/json to UnmarshalWithCaseSensitivePreserveInts in the fakeclient.

Resolves #3207

NOTE: https://pkg.go.dev/sigs.k8s.io/json#UnmarshalCaseSensitivePreserveInts

UnmarshalCaseSensitivePreserveInts parses the JSON-encoded data and stores the result in the value pointed to by v.

UnmarshalCaseSensitivePreserveInts matches the behavior of encoding/json#Unmarshal, with the following changes:

When unmarshaling into a struct, JSON keys must case-sensitively match json tag names (for tagged struct fields) or struct field names (for untagged struct fields), or they are treated as unknown fields and discarded.

When unmarshaling a number into an interface value, it is unmarshaled as an int64 if the JSON data does not contain a "." character and parses as an integer successfully and does not overflow int64. Otherwise, the number is unmarshaled as a float64.

If a syntax error is returned, it will not be of type encoding/json#SyntaxError, but will be recognizeable by this package's IsSyntaxError() function

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: troy0820
Once this PR has been reviewed and has the lgtm label, please assign vincepri for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[camilamacedo86]

Could it be in with the others ones?

[troy0820]

Yes, this is actually in k8s.io/apimachinery/pkg/util/json which has an Unmarshal method. That method calls the method UnmarshalCaseSensitivePreserveInts

https://github.com/kubernetes/apimachinery/blob/d56afd172ac5d1ce5afe66caedf3e663a56433f5/pkg/util/json/json.go#L45C1-L47C2

[alvaroaleman]

Lets please add a test for the issue, otherwise this will likely break again in the future

[sbueringer]

[I might be mixing up stuff]

IIRC this is heavily aligned to the upstream client-go fake client and we want to avoid differences in behavior.

What is the upstream fake client doing here? (or is it not using the json package at all and this is just from additional code that we have here)

[troy0820]

IIRC this is heavily aligned to the upstream client-go fake client and we want to avoid differences in behavior.

What is the upstream fake client doing here? (or is it not using the json package at all and this is just from additional code that we have here)

I am not seeing anything in client-go fakeclient where this would be present. I may be overlooking it but it seems they use k8s.io/apimachinery/pkg/util/json in client-go but not for the fakeclient. They are using instances of encoding/json to Marshal for the ApplyConfigurations.

[alvaroaleman]

@sbueringer I think you are confusing this with json patch, I don't think there is any reason for upstream to do json encoding in the fake client. We need it because of edge cases like "Object gets stored and retrieved in different representations like unstructured/structure", that issue does not exist in upstream fake clients as they don't support that

[sbueringer]

Sounds good, thx for the additional info!

I know that it's not the json patch case, was just wondering if it's a similar case

[troy0820]

/hold