🌱metrics: Expose client-go metrics in the metrics server #3205
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ahmetb The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/L
ahmetb
force-pushed
the
ahmet/client-go-metrics
branch
from
173c1ea to
b53f68d
Compare
Problem: Currently the only client-side metric enabled in the controller processes is `rest_client_requests_total`, which is pretty limited. This patch starts exporting more client-side metrics offered by client-go in the controller process by default by copying what `component-base` does for core Kubernetes components.
ahmetb
force-pushed
the
ahmet/client-go-metrics
branch
from
b53f68d to
1b71fce
Compare
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
There was a problem hiding this comment.
Can you please adopt native histograms like I did here #3165?
|
@krisztianfekete: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| @@ -1,5 +1,5 @@ | |||
| /* | |||
There was a problem hiding this comment.
NIT: The emoji should be ✨
(🌱 means that those changes would result in 0 impact on the end users - i.e. CI changes)
|
Thx for opening the PR to provide more context to the proposal issue. /hold |
k8s-ci-robot
added
the
do-not-merge/hold
Problem: (Described in detail at #3202.) Currently the only client-side metric enabled in the controller processes is
rest_client_requests_total, which is pretty limited.This patch starts exporting more client-side metrics offered by client-go in the controller process by default by copying what
component-basedoes for core Kubernetes components.Closes #3202.