Skip to content

fix: Remove multiple console.log and fix reference to undefined submitButtonLabel #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2024

Conversation

pgoforth
Copy link

@pgoforth pgoforth commented Sep 17, 2024

Fixing a reference to submitButtonLabel. There is already a property for submitButtonText that is hooked up as a reactive property. I reused that property so that there would be a re-render in response to a change. @JulianCataldo please let me know if we should just rename the property to submitButtonLabel.

Additionally, there shouldn't be any extraneous console logs when this is used as a third-party library.

@JulianCataldo JulianCataldo merged commit 93e7415 into json-schema-form-element:next Sep 21, 2024
@pgoforth pgoforth deleted the cleanup branch September 30, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants