Skip to content

Address some possible issues in 1.2.11 #2134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2020
Merged

Address some possible issues in 1.2.11 #2134

merged 1 commit into from
Sep 23, 2020

Conversation

vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt commented Sep 20, 2020

  1. Fix some typos.
  2. Replace == with === in a task when it is appropriate to make reader accustomed to good practice.
  3. Fix some metrics in SVG that caused ugly effect in dark browser mode.

@iliakan
Copy link
Member

iliakan commented Sep 22, 2020

What did you fix in SVGs? We use Sketch as the editor, and SVGs are auto-exported, so I'd better fix it there.

@vsemozhetbyt
Copy link
Contributor Author

I will be able to tell a bit later. Some text was out of colored boxes in dark mode, so I may decrease font size and change coordinates.

@vsemozhetbyt
Copy link
Contributor Author

vsemozhetbyt commented Sep 22, 2020

Here is the screenshot of current svg from my phone, so I think I've changed the ECMASript block. And maybe l've moved "You don't know...' a bit to the left side, I am not sure now, sorry.

screenshot

Screenshot_2020-09-22-15-09-15-020_com android chrome

@iliakan
Copy link
Member

iliakan commented Sep 22, 2020

It seems, you changed another svg: ifelse_task.svg

@vsemozhetbyt
Copy link
Contributor Author

vsemozhetbyt commented Sep 22, 2020

Sorry, wrong PR.

Here, "TheMaster" may be the issue.

screenshot

Screenshot_2020-09-22-15-31-49-455_com android chrome

@vsemozhetbyt
Copy link
Contributor Author

Sorry for the mess, trying to answer from the subway.

@vsemozhetbyt
Copy link
Contributor Author

vsemozhetbyt commented Sep 22, 2020

Should I exclude svg from this PR?
(Sorry, it seems I have not changed 1-js/02-first-steps/10-ifelse/2-check-standard/ifelse_task2.svg in the previous PR, so maybe it also needs your attention because of "ECMASript" block issue).

@iliakan
Copy link
Member

iliakan commented Sep 22, 2020

Please change it in the sketch instead

1 similar comment
@iliakan
Copy link
Member

iliakan commented Sep 22, 2020

Please change it in the sketch instead

@iliakan
Copy link
Member

iliakan commented Sep 22, 2020

Or maybe better just don’t touch svgs at all. Anyway will need a total revision of all svgs for the dark mode

@vsemozhetbyt
Copy link
Contributor Author

SVG excluded.

@iliakan
Copy link
Member

iliakan commented Sep 23, 2020

Thanks!

@iliakan iliakan merged commit 2aad40b into javascript-tutorial:master Sep 23, 2020
@vsemozhetbyt vsemozhetbyt deleted the 1.2.11 branch September 23, 2020 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants