-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Address some possible issues in 1.2.11 #2134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
What did you fix in SVGs? We use Sketch as the editor, and SVGs are auto-exported, so I'd better fix it there. |
I will be able to tell a bit later. Some text was out of colored boxes in dark mode, so I may decrease font size and change coordinates. |
It seems, you changed another svg: ifelse_task.svg |
Sorry for the mess, trying to answer from the subway. |
Should I exclude svg from this PR? |
Please change it in the sketch instead |
1 similar comment
Please change it in the sketch instead |
Or maybe better just don’t touch svgs at all. Anyway will need a total revision of all svgs for the dark mode |
SVG excluded. |
Thanks! |
==
with===
in a task when it is appropriate to make reader accustomed to good practice.Fix some metrics in SVG that caused ugly effect in dark browser mode.