Skip to content

Depending on Guava 26.0-jre introduces test failures #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Capstan opened this issue Sep 4, 2019 · 2 comments · Fixed by #77
Closed

Depending on Guava 26.0-jre introduces test failures #59

Capstan opened this issue Sep 4, 2019 · 2 comments · Fixed by #77
Labels
bug

Comments

@Capstan
Copy link
Contributor

Capstan commented Sep 4, 2019 

java.lang.NoSuchFieldError: JAVA_ISO_CONTROL
	at com.github.fge.uritemplate.parse.CharMatchers.<clinit>(CharMatchers.java:40)

https://github.com/fge/uri-template/blob/master/src/main/java/com/github/fge/uritemplate/parse/CharMatchers.java
@Capstan
Copy link
Contributor Author

Capstan commented Sep 4, 2019

See also fge/uri-template#4 (comment) Will probably have to clone fge/uri-template into java-json-tools if we want to keep Guava up to date.

Capstan added a commit to Capstan/json-schema-core that referenced this issue Sep 4, 2019
@Capstan
Add missing dependencies.
b162078 
* Jackson-Databind
* Guava, pinned at 25.1-jre due to java-json-tools#59.

Fixes java-json-tools#49.
@Capstan Capstan mentioned this issue Sep 4, 2019
Merged
Capstan added a commit that referenced this issue Sep 4, 2019
@Capstan
Add missing dependencies.
503b633 
* Jackson-Databind
* Guava, pinned at 25.1-jre due to #59.

Fixes #49.
Capstan added a commit to Capstan/jackson-coreutils that referenced this issue Sep 4, 2019
@Capstan
Downgrade Guava to 25.1-jre.
ee401d7 
Otherwise, we run into java-json-tools/json-schema-core#59. It still is beyond 24.1.1, which has [CVE-2018-10237](https://nvd.nist.gov/vuln/detail/CVE-2018-10237).
@Capstan Capstan mentioned this issue Sep 4, 2019
Merged
Capstan added a commit to java-json-tools/jackson-coreutils that referenced this issue Sep 4, 2019
@Capstan
Downgrade Guava to 25.1-jre.
e64986b 
Otherwise, we run into java-json-tools/json-schema-core#59. It still is beyond 24.1.1, which has [CVE-2018-10237](https://nvd.nist.gov/vuln/detail/CVE-2018-10237).
@Capstan Capstan added the bug label Sep 5, 2019
Capstan added a commit to Capstan/uri-template that referenced this issue Oct 30, 2019
@Capstan
Bump Guava to 28.1-android.
b491536 
Now that we're using the android track with support for Java 7, we shouldn't run into missing symbols errors. See java-json-tools/json-schema-core/issues/59.

Fixes #
Capstan added a commit to Capstan/uri-template that referenced this issue Oct 30, 2019
@Capstan
Bump Guava to 28.1-android.
2d0e988 
Now that we're using the android track with support for Java 7, we shouldn't run into missing symbols errors. See java-json-tools/json-schema-core/issues/59.
@Capstan Capstan mentioned this issue Oct 30, 2019
Merged
Capstan added a commit to java-json-tools/uri-template that referenced this issue Oct 30, 2019
@Capstan
Bump Guava to 28.1-android.
6e86f28 
Now that we're using the android track with support for Java 7, we shouldn't run into missing symbols errors. See java-json-tools/json-schema-core/issues/59.
Capstan added a commit to Capstan/jackson-coreutils that referenced this issue Oct 30, 2019
@Capstan
Bump Guava to 28.1-android.
f0d2b18 
Now that we're using the android track with support for Java 7, we shouldn't run into missing symbols errors. See java-json-tools/json-schema-core/issues/59.
@Capstan Capstan mentioned this issue Oct 30, 2019
Merged
Capstan added a commit to java-json-tools/jackson-coreutils that referenced this issue Oct 30, 2019
@Capstan
Bump Guava to 28.1-android.
c76de33 
Now that we're using the android track with support for Java 7, we shouldn't run into missing symbols errors. See java-json-tools/json-schema-core/issues/59.
@Capstan
Copy link
Contributor Author

Capstan commented Oct 30, 2019

At this point, if we import the older uri-template against the newer Guava, the JAVA_ISO_CONTROL message is gone, and this causes the error. In order to commit the bump to json-schema-core, I'll have to at least create a snapshot release to reference.

Capstan added a commit to Capstan/json-schema-core that referenced this issue Oct 31, 2019
@Capstan
Bump Guava to 28.1-android.
0a97469 
Now that we're using the android track with support for Java 7, we shouldn't run into missing symbols errors. Fixes java-json-tools#59.
@Capstan Capstan mentioned this issue Oct 31, 2019
Merged
Capstan added a commit that referenced this issue Oct 31, 2019
@Capstan
Bump Guava to 28.1-android.
00b2451 
Now that we're using the android track with support for Java 7, we shouldn't run into missing symbols errors. Fixes #59.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump Guava to 28.1-android. Capstan/json-schema-core
1 participant
@Capstan