Skip to content

chore: make ionic 8 default version #3600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
6 changes: 3 additions & 3 deletions docs/theming/dark-mode.md
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ It is important to pay attention to the specificity if you want to override any
:::

:::info
The contents of Ionic's dark palette can be [viewed on GitHub](https://github.com/ionic-team/ionic-framework/blob/feature-8.0/core/src/css/palettes/dark.scss). The CSS used to apply the **always** dark palette can be found [here](https://github.com/ionic-team/ionic-framework/blob/feature-8.0/core/src/css/palettes/dark.always.scss).
The contents of Ionic's dark palette can be [viewed on GitHub](https://github.com/ionic-team/ionic-framework/blob/main/core/src/css/palettes/dark.scss). The CSS used to apply the **always** dark palette can be found [here](https://github.com/ionic-team/ionic-framework/blob/main/core/src/css/palettes/dark.always.scss).
:::

</TabItem>
Expand All @@ -244,7 +244,7 @@ It is important to pay attention to the specificity if you want to override any
:::

:::info
The contents of Ionic's dark palette can be [viewed on GitHub](https://github.com/ionic-team/ionic-framework/blob/feature-8.0/core/src/css/palettes/dark.scss). The CSS used to apply the **system** dark palette can be found [here](https://github.com/ionic-team/ionic-framework/blob/feature-8.0/core/src/css/palettes/dark.system.scss).
The contents of Ionic's dark palette can be [viewed on GitHub](https://github.com/ionic-team/ionic-framework/blob/main/core/src/css/palettes/dark.scss). The CSS used to apply the **system** dark palette can be found [here](https://github.com/ionic-team/ionic-framework/blob/main/core/src/css/palettes/dark.system.scss).
:::

</TabItem>
Expand All @@ -262,7 +262,7 @@ It is important to pay attention to the specificity if you want to override any
:::

:::info
The contents of Ionic's dark palette can be [viewed on GitHub](https://github.com/ionic-team/ionic-framework/blob/feature-8.0/core/src/css/palettes/dark.scss). The CSS used to apply the **class** dark palette can be found [here](https://github.com/ionic-team/ionic-framework/blob/feature-8.0/core/src/css/palettes/dark.class.scss).
The contents of Ionic's dark palette can be [viewed on GitHub](https://github.com/ionic-team/ionic-framework/blob/main/core/src/css/palettes/dark.scss). The CSS used to apply the **class** dark palette can be found [here](https://github.com/ionic-team/ionic-framework/blob/main/core/src/css/palettes/dark.class.scss).
:::

</TabItem>
Expand Down
47 changes: 30 additions & 17 deletions docs/updating/8-0.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ This guide assumes that you have already updated your app to the latest version
:::

:::info Breaking Changes
For a **complete list of breaking changes** from Ionic 7 to Ionic 8, please refer to [the breaking changes document](https://github.com/ionic-team/ionic-framework/blob/feature-8.0/BREAKING.md#version-8x) in the Ionic Framework repository.
For a **complete list of breaking changes** from Ionic 7 to Ionic 8, please refer to [the breaking changes document](https://github.com/ionic-team/ionic-framework/blob/main/BREAKING.md#version-8x) in the Ionic Framework repository.
:::

## Getting Started
Expand Down Expand Up @@ -138,24 +138,30 @@ Using the newly imported dark palette mentioned above will also import these new

`--ion-color-step-[number]` usages for **background color** can be migrated by renaming the token to `--ion-background-color-step-[number]`.

**Example**:
**Before**:

```diff
button {
- background: var(--ion-color-step-400);
+ background: var(--ion-background-color-step-400);
}
```html
button { background: var(--ion-color-step-400); }
```

**After**:

```html
button { background: var(--ion-background-color-step-400); }
```

`--ion-color-step-[number]` usages for **text color** can be migrated by renaming the token to `--ion-text-color-step-[number]` and subtracting the number from 1000.

**Example**:
**Before**:

```diff
button {
- color: var(--ion-color-step-400);
+ color: var(--ion-text-color-step-600); /* 1000 - 400 = 600 */
}
```html
button { color: var(--ion-color-step-400); }
```

**After**:

```html
button { color: var(--ion-text-color-step-600); /* 1000 - 400 = 600 */ }
```

The [stepped color generator](../theming/themes#stepped-color-generator) has been updated to generate text and background color stepped variables.
Expand All @@ -178,9 +184,16 @@ The `angular.json` file currently imports `src/theme/variables.scss` before impo

We recommend importing the `src/global.scss` file first instead:

```diff
- "styles": ["src/theme/variables.scss", "src/global.scss"],
+ "styles": ["src/global.scss", "src/theme/variables.scss"],
**Before**:

```json
"styles": ["src/theme/variables.scss", "src/global.scss"],
```

**After**:

```json
"styles": ["src/global.scss", "src/theme/variables.scss"],
```

## Required Changes
Expand Down Expand Up @@ -246,6 +259,6 @@ iOS >=15

## Need Help Upgrading?

Be sure to look at the [Ionic 8 Breaking Changes Guide](https://github.com/ionic-team/ionic-framework/blob/feature-8.0/BREAKING.md#version-8x). There were several changes to default property and CSS Variable values that developers may need to be aware of. Only the breaking changes that require user action are listed on this page.
Be sure to look at the [Ionic 8 Breaking Changes Guide](https://github.com/ionic-team/ionic-framework/blob/main/BREAKING.md#version-8x). There were several changes to default property and CSS Variable values that developers may need to be aware of. Only the breaking changes that require user action are listed on this page.

If you need help upgrading, please post a thread on the [Ionic Forum](https://forum.ionicframework.com/).
13 changes: 4 additions & 9 deletions docusaurus.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -80,15 +80,10 @@ module.exports = {
return `https://github.com/ionic-team/ionic-docs/edit/main/${versionDocsDirPath}/${docPath}`;
},
exclude: ['README.md'],
lastVersion: 'v7',
lastVersion: 'current',
versions: {
current: {
label: 'v8 (beta)',
banner: 'unreleased',
path: 'v8',
},
v7: {
label: 'v7',
label: 'v8',
},
},
},
Expand Down Expand Up @@ -182,8 +177,8 @@ module.exports = {
},
{
type: 'doc',
docId: 'updating/7-0',
label: 'Ionic v7.0.0 Upgrade Guide',
docId: 'updating/8-0',
label: 'Ionic v8.0.0 Upgrade Guide',
position: 'left',
className: 'cta',
},
Expand Down
4 changes: 2 additions & 2 deletions static/code/stackblitz/v8/angular/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"dependencies": {
"@ionic/angular": "next",
"@ionic/core": "next",
"@ionic/angular": "8.0.0",
"@ionic/core": "8.0.0",
"@angular/platform-browser-dynamic": "17.3.2"
}
}
4 changes: 2 additions & 2 deletions static/code/stackblitz/v8/html/index.html
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<html>

<head>
<link rel="stylesheet" type="text/css" href="https://cdn.skypack.dev/@ionic/core@next/css/core.css" />
<link rel="stylesheet" type="text/css" href="https://cdn.skypack.dev/@ionic/core@next/css/ionic.bundle.css" />
<link rel="stylesheet" type="text/css" href="https://cdn.skypack.dev/@ionic/core@8/css/core.css" />
<link rel="stylesheet" type="text/css" href="https://cdn.skypack.dev/@ionic/core@8/css/ionic.bundle.css" />
</head>

<body>
Expand Down
2 changes: 1 addition & 1 deletion static/code/stackblitz/v8/html/package.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"dependencies": {
"@ionic/core": "next"
"@ionic/core": "8.0.0"
}
}
72 changes: 36 additions & 36 deletions static/code/stackblitz/v8/react/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions static/code/stackblitz/v8/react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
"version": "0.1.0",
"private": true,
"dependencies": {
"@ionic/react": "next",
"@ionic/react-router": "next",
"@ionic/react": "8.0.0",
"@ionic/react-router": "8.0.0",
"@types/node": "^20.0.0",
"@types/react": "^18.0.9",
"@types/react-dom": "^18.0.4",
Expand Down
Loading