Skip to content

docs(datetime): add highlightedDates playgrounds #2769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 22, 2023
Merged

Conversation

averyjohnston
Copy link
Contributor

@averyjohnston averyjohnston commented Feb 13, 2023

Adds playgrounds for the new highlightedDates property added here: ionic-team/ionic-framework#26775 Demos for using the prop as both an array and a callback are included, as well as versions for both v6 and v7.

Dev build for feature: 6.5.3-dev.11676573595.1564fefe

@vercel
Copy link

vercel bot commented Feb 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
ionic-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 20, 2023 at 5:08PM (UTC)

Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The demo in MD mode does not work for some reason. Also every time I click it switches months. Interestingly, when I reset the demo it works:

Screen.Recording.2023-02-17.at.9.25.45.AM.mov

@averyjohnston
Copy link
Contributor Author

The demo in MD mode does not work for some reason. Also every time I click it switches months.

Looks like this is a separate bug; I'm able to replicate it in the live v6 and v7 docs too. (It might take a few refreshes.) I'm unsure whether the resolution will be on the framework or the playground component itself, but it's most obviously manifesting in the docs, so I filed an issue there: #2778

Copy link
Contributor

@sean-perkins sean-perkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change that applies to all of the top-level playground index.md files.

Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

Copy link
Contributor

@sean-perkins sean-perkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@averyjohnston averyjohnston merged commit 8036f63 into feature-6.6 Feb 22, 2023
@averyjohnston averyjohnston deleted the FW-2142 branch February 22, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants