Skip to content

docs: add stackblitz playground for theming #1648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Sep 11, 2020

Description

Add stackblitz for theming and manual dark mode docs for Angular and React

Link to stackblitz
Angular - https://stackblitz.com/edit/ionic-ng-theming
React - https://stackblitz.com/edit/ionic-react-theming

Screenshots

image

@averyjohnston
Copy link
Contributor

Thank you for the PR! We greatly appreciate the work you've put in. In the time since this was posted, we've updated the docs with playgrounds/live demos that include code for all major frameworks Ionic supports. (You can see examples on the component docs, such as here.) Rather than link to additional sandboxes, we should replace the ones on this page with equivalent playgrounds. This will also include example code for Vue.

I've created #2998 to track this work effort, and raised it internally with the team. I've also made sure to add a note about your PR so that we can give you co-author credit when adding the new demos.

I'm going to close this out in lieu of the above changes, but let me know if you have any questions, and thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants