Skip to content
This repository was archived by the owner on Oct 29, 2024. It is now read-only.

Remove the cluster client #339

Closed
aviau opened this issue Jun 13, 2016 · 5 comments
Closed

Remove the cluster client #339

aviau opened this issue Jun 13, 2016 · 5 comments

Comments

@aviau
Copy link
Collaborator

aviau commented Jun 13, 2016

The cluster client no longer makes sense with recent patches.

Don't forget:

  • remove the example in the README.
  • remove the section in api-documentation.rst
gaker added a commit to gaker/influxdb-python that referenced this issue Jul 29, 2016
@aviau aviau closed this as completed Nov 1, 2016
@PierreF
Copy link
Contributor

PierreF commented Dec 8, 2016

Hi,
which recent patches do you refer to ?
Or are you referring to InfluxDB itself that no longer support cluster ?

we are still using InfluxDB 0.11 with cluster, and that feature of influxdb-python was useful to us :(

@aviau
Copy link
Collaborator Author

aviau commented Dec 9, 2016

Or are you referring to InfluxDB itself that no longer support cluster ?

Yes, that.

we are still using InfluxDB 0.11 with cluster, and that feature of influxdb-python was useful to us :(

okay.

  • You may open a pull request that adds the cluster client back, and I would consider merging it for backwards compatibility. However, please move it into another module just like I did with influxdb08

  • You can use an older version of the client

@PierreF
Copy link
Contributor

PierreF commented Dec 9, 2016

Fine, thanks for taking time to explain the removal.

I've created a PR (#396) to re-add the cluster in a legacy module with warning that state this cluster client must NOT be used with newer influxdb-relay cluster.

@Rob-DL
Copy link

Rob-DL commented Dec 21, 2016

We are using the latest commercial version of InfluxDB (v1.2 Enterprise) which does not rely on a relay server. This means the load balancing still needs to be done on the client, hence there is still a strong use case for the ClusterClient. The removal of this functionality means that we cannot upgrade to the latest release of influxdb-python.

Are there any plans to support Influx-Enterprise?

@PierreF
Copy link
Contributor

PierreF commented Dec 22, 2016

PR #396 should works with latest InfluxDB enterprise cluster, it only require that all nodes are equivalent: writing on one node is replicated by the node to the other nodes; reading from any node return the same data

But since the ClusterClient is still useful in Influxdb enterprise, maybe the PR should not move it to a "legacy" module, but not normal module and/or "enterprise" module (e.g. with due warning that it does not works with relay cluster). What do you think @aviau, should I update the PR in this way ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants