Skip to content

feat: introduce rrweb table to store session replay data #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 31, 2025

Conversation

wrn14897
Copy link
Member

No description provided.

Copy link

changeset-bot bot commented Jan 30, 2025

⚠️ No Changeset found

Latest commit: bcd5f21

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -1,70 +0,0 @@
receivers:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replaced this with config.yaml since they are identical

LYHuang
LYHuang previously approved these changes Jan 31, 2025
default_pipelines: [logs/out-default]
error_mode: ignore
table:
- statement: route() where IsMatch(attributes["rum.sessionId"], ".*")
Copy link
Contributor

@MikeShi42 MikeShi42 Jan 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to match based on something a bit more robust to the session replay event itself? Like the scope name being rum.rr-web or attributes like rr-web.event? I'm just thinking it's possible in the future we'll have logs that will have that rum.sessionId attribute

fwiw I'm fine if this is ticketed up for later

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought about it but I got the invalid log context issue (related to this open-telemetry/opentelemetry-collector-contrib#37410). It seems the older version works properly. Let me update it

MikeShi42
MikeShi42 previously approved these changes Jan 31, 2025
@wrn14897 wrn14897 dismissed stale reviews from MikeShi42 and LYHuang via 2877538 January 31, 2025 19:32
@kodiakhq kodiakhq bot merged commit 7c3ac9b into v2 Jan 31, 2025
4 checks passed
@kodiakhq kodiakhq bot deleted the warren/rrweb-ch-exporter branch January 31, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants