-
Notifications
You must be signed in to change notification settings - Fork 250
feat: introduce rrweb
table to store session replay data
#586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@@ -1,70 +0,0 @@ | |||
receivers: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replaced this with config.yaml
since they are identical
docker/otel-collector/config.yaml
Outdated
default_pipelines: [logs/out-default] | ||
error_mode: ignore | ||
table: | ||
- statement: route() where IsMatch(attributes["rum.sessionId"], ".*") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to match based on something a bit more robust to the session replay event itself? Like the scope name being rum.rr-web
or attributes like rr-web.event
? I'm just thinking it's possible in the future we'll have logs that will have that rum.sessionId attribute
fwiw I'm fine if this is ticketed up for later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thought about it but I got the invalid log context issue (related to this open-telemetry/opentelemetry-collector-contrib#37410). It seems the older version works properly. Let me update it
No description provided.