Skip to content

Add restart command. #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 4, 2020
Merged

Add restart command. #191

merged 3 commits into from
Feb 4, 2020

Conversation

gdziadkiewicz
Copy link
Contributor

@gdziadkiewicz gdziadkiewicz commented Jan 13, 2020

Fix #46

@gdziadkiewicz gdziadkiewicz marked this pull request as ready for review January 20, 2020 19:37
@alanz
Copy link
Collaborator

alanz commented Jan 21, 2020

Please resolve the conflict, then we can see about merging and releasing

@gdziadkiewicz
Copy link
Contributor Author

@alanz Resolved the conflicts.

How did I test it?

Provided solution works for my scenario which is creating the stack.yaml on the fly and making the extension take it into account without restarting VS Code.

Additions

I considered:

  • adding message boxes for the user to know better what did or didn't happen
  • not restarting all of the langclients

Does any of those additions sound usable from your perspective?

@alanz
Copy link
Collaborator

alanz commented Jan 22, 2020

How does the restart work? Is it activated via the Command Palette? Because when it is done you should get the message from hie giving its version

@gdziadkiewicz
Copy link
Contributor Author

gdziadkiewicz commented Jan 22, 2020 via email

@gdziadkiewicz
Copy link
Contributor Author

restart
output.log

@jneira jneira requested a review from alanz January 31, 2020 10:14
@alanz alanz merged commit 002c399 into haskell:master Feb 4, 2020
@gdziadkiewicz gdziadkiewicz deleted the Add_restart branch February 4, 2020 09:24
@jneira
Copy link
Member

jneira commented Feb 4, 2020

@gdziadkiewicz thanks for the pr! we'll try to do a release asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command to restart hie
4 participants