Add thread id in ghcide tests log #4204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soulomoon
changed the title
…dId-in-ghcide-tests' into soulomoon/add-threadId-in-ghcide-tests
michaelpj
reviewed
May 3, 2024
| @@ -73,7 +73,7 @@ main = withTelemetryRecorder $ \telemetryRecorder -> do | |||
| -- stderr recorder just for plugin cli commands | |||
| pluginCliRecorder <- | |||
| cmapWithPrio pretty | |||
| <$> makeDefaultStderrRecorder (Just [PriorityColumn, DataColumn]) | |||
| <$> makeDefaultStderrRecorder (Just [ThreadIdColumn, PriorityColumn, DataColumn]) | |||
There was a problem hiding this comment.
Hmm, this seems like it will affect people using the ghcide executable directly? Well, hopefully that will go away in due course anyway...
There was a problem hiding this comment.
Yes, I am under the impression ghcide is just used for test purpose now and we are considering removing it?
michaelpj
approved these changes
May 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is done:
We need to enable it in two places of ghcide, one in the ghcide exe directly, other is in the main entry of the ghcide test