Generalize formatter plugin support, add Floskell #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First pass only, need to (re-)enable tests, and find a way of selecting between multiple formatters. Apart from only installing a single formatter plugin.
alanz
force-pushed
the
add-floskell-formatter
branch
from
8cb8551 to
ab1ef25
Compare
Needs haskell/ghcide#412 to land first, as a basis for the needed changes
Closed
The floskell formatting is not correct, but this is initially about getting the plugin machinery into place.
fendor
reviewed
Feb 17, 2020
Comment on lines
+117
to
+121
| lookupBiosComponentOptions :: (Monad m) => NormalizedFilePath -> m (Maybe BIOS.ComponentOptions) | ||
| lookupBiosComponentOptions _fp = do | ||
| -- gmc <- getModuleCache | ||
| -- return $ lookupInCache fp gmc (const Just) (Just . compOpts) Nothing | ||
| return Nothing |
There was a problem hiding this comment.
What is that? Looks like an artefact
There was a problem hiding this comment.
It needs to be reinstated at some point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass only, need to (re-)enable tests, and find a way of selecting between
multiple formatters. Apart from only installing a single formatter plugin.
Note: this PR currently depends on #41, so is much noisier than it should be.
Published as a "show and tell"