Improve missing brittany format provider error message (#269) #414
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have tested this error message with cabal. By setting
haskell-language-server/haskell-language-server.cabal
:to
using
cabal build exe:haskell-language-server
And after setting my editor to use
cabal exec which haskell-language-server
and the Brittany formatter. I can see the error message show up correctly.I thought about adding a test to
haskell-language-server/test/functional/Format.hs
for whenAGPL
is false, but wasn't sure if it would ever be run. Do CI tests with this flag on or off?Please let me know if style should be changed or if the error message is too verbose.