Skip to content

Improve missing brittany format provider error message (#269) #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 14, 2020
Merged

Improve missing brittany format provider error message (#269) #414

merged 2 commits into from
Nov 14, 2020

Conversation

willbush
Copy link
Contributor

I have tested this error message with cabal. By setting haskell-language-server/haskell-language-server.cabal:

flag agpl
  description: Enable AGPL dependencies
  default:     True
  manual:      True

to

flag agpl
  description: Enable AGPL dependencies
  default:     False
  manual:      True

using cabal build exe:haskell-language-server

And after setting my editor to use cabal exec which haskell-language-server and the Brittany formatter. I can see the error message show up correctly.

I thought about adding a test to haskell-language-server/test/functional/Format.hs for when AGPL is false, but wasn't sure if it would ever be run. Do CI tests with this flag on or off?

Please let me know if style should be changed or if the error message is too verbose.

Copy link
Collaborator

@lukel97 lukel97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, this is a good idea. Thanks!

@jneira
Copy link
Member

jneira commented Nov 14, 2020

@willbush wow, many thanks and sorry for the delay, merging!

@jneira jneira merged commit 3120065 into haskell:master Nov 14, 2020
pepeiborra added a commit that referenced this pull request Dec 27, 2020
* Fix ModLocation creation

* Simplify
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants