Extract last 2 plugins and clean up others #1836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ailrun
force-pushed
the
extract-and-clean-up
branch
from
b052448 to
1d471f8
Compare
Ailrun
changed the title
Ailrun
force-pushed
the
extract-and-clean-up
branch
from
1d471f8 to
f9889ae
Compare
Ailrun
commented
May 16, 2021
jneira
approved these changes
May 16, 2021
|
@Ailrun completely fine to rename the Wingman tests! thanks for tackling this! |
Ailrun
force-pushed
the
extract-and-clean-up
branch
from
f9889ae to
b6f2e34
Compare
Ailrun
force-pushed
the
extract-and-clean-up
branch
from
8fee8f1 to
1d2458b
Compare
Ailrun
force-pushed
the
extract-and-clean-up
branch
2 times, most recently
from
dd963cd to
9360c7a
Compare
Ailrun
force-pushed
the
extract-and-clean-up
branch
from
9360c7a to
9667701
Compare
Ailrun
commented
May 17, 2021
| @@ -61,7 +61,7 @@ codeActionTitle (InR(CodeAction title _ _ _ _ _ _ _)) = Just title | |||
| mkTest | |||
| :: Foldable t | |||
| => String -- ^ The test name | |||
| -> FilePath -- ^ The file to load | |||
| -> FilePath -- ^ The file basename to load | |||
There was a problem hiding this comment.
It's not "basename", it's a stem.
Ailrun
commented
May 17, 2021
Ailrun
force-pushed
the
extract-and-clean-up
branch
from
9271129 to
71c6f7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract
(last 2 plugins reside in
defaultdirectory) and clean up cabal files & tests of other plugins.Although I think it's generally better to use
.hsextensions even for golden files so that we can have syntax highlight and others, I didn't touch Wingman's tests as I am not sure whether any of @isovector's tools depend on golden test extensions or not. Is it OK to update Wingman's tests so that we have.expected.hsor similar.