Skip to content

Add restart command #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ndmitchell opened this issue Jan 28, 2020 · 8 comments
Closed

Add restart command #979

ndmitchell opened this issue Jan 28, 2020 · 8 comments

Comments

@ndmitchell
Copy link
Collaborator

The Rust IDE provides a VS Code action to restart the IDE server - which lets you both experiment and work around bugs quickly without restarting the entire IDE. Would be super useful to have in the extension.

@fendor
Copy link
Collaborator

fendor commented Jan 28, 2020

Maybe interesting: haskell/vscode-haskell#191

@cocreature
Copy link
Contributor

Doesn’t Control-Shift-P -> Reload Window already achieve that?

@ocharles
Copy link
Contributor

ocharles commented Jan 28, 2020

This seems like a very VS code specific feature. For those of us in Emacs, we can already do lsp-workspace-restart to restart ghcide.

@ndmitchell
Copy link
Collaborator Author

@cocreature reload let's you do it and more - too much more - clearing editor context, active searches, terminal windows and the like. It is entirely a vs code feature and may well end up exclusively in the TypeScript per of the project.

@cocreature
Copy link
Contributor

If we get to the point that the fact that reload window resets too much becomes a problem, I think we have much bigger problem. This should be an escape hatch that you basically never have to use so I don’t think we should rather fix whatever causes people to invoke it then spend time on making the restart experience nicer.

@ndmitchell
Copy link
Collaborator Author

We're at that point already. See haskell/ghcide#381. What happens when I upgrade stack. Or install something in my global package dB. Or upgrade ghcide. I've had all those happen yesterday. Rust is way more stable as an IDE and even there it's not uncommon to need to unstick it. I agree we should minimise the issues, and fix most of them, but not having the easy fix just hurts.

@cocreature
Copy link
Contributor

Fair, I guess adding some logic for restarts to the VSCode extension shouldn’t be too hard.

@ndmitchell
Copy link
Collaborator Author

VSCode added a "Restart Extension Host" command which restarts all extensions, but for my use cases, is close enough to what I want here. My desire for this feature has gone, so closing this ticket (but if anyone else with a different editor feels it would be useful please reopen).

@pepeiborra pepeiborra transferred this issue from haskell/ghcide Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants