Skip to content

Allow using LambdaCase in case splitting plugin #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
expipiplus1 opened this issue Sep 11, 2020 · 4 comments · Fixed by #431
Closed

Allow using LambdaCase in case splitting plugin #394

expipiplus1 opened this issue Sep 11, 2020 · 4 comments · Fixed by #431
Labels
component: plugins component: wingman type: enhancement New feature or request

Comments

@expipiplus1
Copy link
Contributor

It would be nice if case splitting were configurable to generate LambdaCase splits. This could either be a static configuration option, or an additional suggestion in every split.

For the example here: #391 (comment)

fmapEither = \fab -> \case
  Left c -> Left _ 
  Right a -> Right _
@expipiplus1 expipiplus1 mentioned this issue Sep 11, 2020
Merged
@isovector
Copy link
Collaborator

I plan to tackle this.

@jneira
Copy link
Member

jneira commented Sep 11, 2020

This deserves a special label 😉

@jneira jneira linked a pull request Sep 23, 2020 that will close this issue
Case splitting and lambda introduction #391
Merged
@jneira jneira removed a link to a pull request Sep 23, 2020
Case splitting and lambda introduction #391
Merged
@isovector
Copy link
Collaborator

isovector commented Sep 30, 2020 •
edited
Loading

Implemented in 84d47cd; this will be fixed when we merge #431. The tactics plugin will suggest a lambda case whenever the type is appropriate and -XLambdaCase is enabled.

@expipiplus1
Copy link
Contributor Author

expipiplus1 commented Oct 1, 2020 via email

@jneira jneira linked a pull request Oct 1, 2020 that will close this issue
Implement 'Attempt to fill hole' code action #431
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: plugins component: wingman type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement 'Attempt to fill hole' code action isovector/haskell-language-server
3 participants
@jneira @isovector @expipiplus1