Skip to content

Release package permissions and file name #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hyiltiz opened this issue Aug 12, 2020 · 8 comments · Fixed by #584
Closed

Release package permissions and file name #316

hyiltiz opened this issue Aug 12, 2020 · 8 comments · Fixed by #584
Labels
type: enhancement New feature or request

Comments

@hyiltiz
Copy link
Contributor

hyiltiz commented Aug 12, 2020

I had to download the pre-built binaries from Github Release, unpack them, chmod +x them and also remove -Linux- in their file name before putting them into $PATH. The steps in bold weren't mentioned in the project Readme.md file. Better yet, would be easier if the file modes and names were set appropriately before archiving them for release.

@rgleichman
Copy link
Contributor

I also encountered this recently when installing Haskell Language Server for the first time. The specific error I got in my Emacs *hie::stderr* buffer was

Project GHC version: 8.8.3
haskell-language-server exe candidates: ["haskell-language-server-8.8.3","haskell-language-server-8.8","haskell-language-server"]
Cannot find any haskell-language-server exe, looked for: haskell-language-server-8.8.3, haskell-language-server-8.8, haskell-language-server
Process hie stderr<1> finished
Process hie stderr finished

@jneira
Copy link
Member

jneira commented Nov 9, 2020

It should not be difficult to change the build script to change the name and set executable permisson (it it is not already done).
Maybe it would need some change in the vscode extension.
//cc @bubba

@lukel97
Copy link
Collaborator

lukel97 commented Nov 11, 2020

@jneira I think the ghcup .tar.gz bundles might fix this issue. Let me check to see if they have the correct permissions

lukel97 added a commit to lukel97/haskell-language-server that referenced this issue Nov 11, 2020
@hyiltiz
Copy link
Contributor Author

hyiltiz commented Nov 11, 2020

9689b83 seems to only address the exec permissions. The other part of the problem is the file name of the executable in the bundle. I think it is reasonable to mention -Linux- in the bundle name, but the exec should be ready to deploy once uncompressed, by a simple cp or ln -s, without also requiring a rename first.

@hyiltiz
Copy link
Contributor Author

hyiltiz commented Nov 11, 2020

Hmm? Accidentally closed by the hook? From the patch that got merged, it doesn't seem to address the renaming yet.

@jneira
Copy link
Member

jneira commented Nov 11, 2020

@hyiltiz yeah, the pr was linked to this issue and closed it

@jneira jneira reopened this Nov 11, 2020
pepeiborra pushed a commit that referenced this issue Dec 27, 2020
The new version introduced a new hint that broke our build.
@sloorush
Copy link
Contributor

I was looking into the issue, but I believe this issue has been fixed in 34e9914.

Is that correct?

@michaelpj
Copy link
Collaborator

The way that we distribute releases has changed hugely, so I suspect this is done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants